WIP: ci: Improve performance of mpich tests in CI #3828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the version of mpich built into the ecpe4s/ubuntu20.04:23.05 image instead of building a new one. This replaces an mpich that used ch3/tcp with one that uses ch4/ofi.
|
@scottwittenburg this looks great, I will give a better review in the coming days |
|
@scottwittenburg does this improved the perf of mpich tests? Maybe we have to run the CI a few times to check this. Note that previously ADIOS2+MPICH+ch4/ofi was very flaky, maybe is not the case anymore with a newer MPICH version. |
No, this didn't help at all, and since it took about an hour (like the previous mpich tests), I'm not sure running more times will help. I may close it, or else use this PR as a way to test other approaches. |
|
@scottwittenburg I guess that this was superseded by #3883, shall we close? |
|
Yes, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version of mpich built into the ecpe4s/ubuntu20.04:23.05 image instead of building a new one. This replaces an mpich that used ch3/tcp with one that uses ch4/ofi.