Skip to content

Conversation

eisenhauer
Copy link
Member

This fixes an OSX 14 problem.

vicentebolea
vicentebolea previously approved these changes Sep 19, 2023
Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@eisenhauer
Copy link
Member Author

@anagainaru Would you please check this one too to see if it works on OSX 14?

@anagainaru
Copy link
Contributor

anagainaru commented Sep 19, 2023

@anagainaru Would you please check this one too to see if it works on OSX 14?

I still see the issue with the version of ffs:

CMake Error at thirdparty/EVPath/EVPath/CMakeLists.txt:204 (find_package):
  Could not find a configuration file for package "ffs" that is compatible
  with requested version "2.0.0".

  The following configuration files were considered but not accepted:

    /Users/95j/work/adios/ADIOS2-main/ADIOS2-mgard/build/thirdparty/ffs/ffs/ffs-config.cmake, version: 3.0.0

@eisenhauer
Copy link
Member Author

There may be some unpleasantness because I force-pushed the prior version, which might have left some stuff sitting around when you pulled the fresh version. (I think this because this change doesn't have the version 3.0.0 stuff in it.) It might be necessary to delete this branch in your current repo and refetch it, and/or blow away the build directory and rebuild.

@anagainaru
Copy link
Contributor

@eisenhauer yes you are right, I did that and now it built just fine. So far it looks good, it's at 20% compiling and no complaints. I'll approve this PR when it finishes

@eisenhauer eisenhauer merged commit 23c8fd5 into ornladios:release_29 Sep 19, 2023
@eisenhauer eisenhauer deleted the FFSUpstream branch September 19, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants