Skip to content

docs(readme): explain behavior of unset auth_tokens and delete_tokens #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2023
Merged

docs(readme): explain behavior of unset auth_tokens and delete_tokens #202

merged 3 commits into from
Dec 11, 2023

Conversation

DDtKey
Copy link
Contributor

@DDtKey DDtKey commented Dec 10, 2023

Description

Just a clarification on how this works in the case of uninstalled tokens, for greater clarity and security

Motivation and Context

Discussed as part of #199, just to clarify the behavior

Changelog Entry

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DDtKey DDtKey requested a review from orhun as a code owner December 10, 2023 17:06
@DDtKey DDtKey force-pushed the mention-token-configuration-in-readme branch from f62e5a2 to a3b1805 Compare December 10, 2023 17:07
@DDtKey
doc(readme): explain behavior of unset auth_tokens & delete_tokens
4b558b5 
Just a clarification on how this works in the case of uninstalled tokens, for greater clarity and security
@DDtKey DDtKey force-pushed the mention-token-configuration-in-readme branch from a3b1805 to 4b558b5 Compare December 10, 2023 17:09
@DDtKey DDtKey mentioned this pull request Dec 10, 2023
Merged
12 tasks
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adbd67a) 70.23% compared to head (4b558b5) 70.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files          11       11           
  Lines         598      598           
=======================================
  Hits          420      420           
  Misses        178      178
Flag Coverage Δ
unit-tests 70.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDtKey DDtKey changed the title doc(readme): explain behavior of unset auth_tokens & delete_tokens docs(readme): explain behavior of unset auth_tokens & delete_tokens Dec 10, 2023
@orhun orhun changed the title docs(readme): explain behavior of unset auth_tokens & delete_tokens docs(readme): explain behavior of unset auth_tokens and delete_tokens Dec 11, 2023
@orhun orhun merged commit b74e9ce into orhun:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DDtKey @codecov-commenter @orhun