Skip to content

chore(project): update crates and rustls deps #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Aug 29, 2023

Description

I didn't see that the bot already opened PRs for the crates. However it also contains an update to use a more recent rustls which uses the replacement (rustls-webpki) for the unmaintained webpki crate.

The updated crates require Rust >= 1.68.0, thus I updated the Dockerfile to use the latest Rust version (1.72.0).

Motivation and Context

Closes #125 #132 #133 #134

How Has This Been Tested?

cargo test
fixtures

Changelog Entry

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: update crates and dependencies for rustls

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner August 29, 2023 21:43
@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

📢 Thoughts on this report? Let us know!.

@tessus
Copy link
Collaborator Author

tessus commented Aug 29, 2023

Not sure why codecov/project complains, because there are no code changes. Weird.

Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for investigating this and creating a PR!

@orhun orhun merged commit 2292c24 into orhun:master Aug 30, 2023
@orhun
Copy link
Owner

orhun commented Aug 30, 2023

@tessus there is another security issue on rustypaste-cli if you want to throw in some thoughts: orhun/rustypaste-cli#49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2023-0052: webpki: CPU denial of service in certificate path building
3 participants