-
-
Notifications
You must be signed in to change notification settings - Fork 60
chore: readme update with unofficial clients #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you put it at the probably worst possible location. ;-)
e.g. the feature flags are a subsection of build from source and you wedged it in between.
Let's put it at the end on the same level as Usage. (most projects put references or alternate projects at the end.)
## 3rd party clients
1.
2.
3.
P.S.: The Table of Contents
should then also be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, once again it is in between subsections. Give me 2 minutes.
@rukh-debug I made a few updates. Please have a look. Are you ok with the update? P.S.: We don't need |
My bad. LGTM now. |
@rukh-debug I saw that you resolved the conversations. I'm just wondering why you did that. I didn't see that you committed the suggestions nor that you pushed any additional commits. Please resolve conversations only after they have been resolved. P.S.: Unless I missed something, in which case please let me know. |
Pardon my ignorance, I’m still learning how pull requests work. I was actually wondering where the branch containing these new changes is located. I just realized I need to make those changes in my own branch first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs(readme): update location again
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Please let me know if there is anything else I need to do from my end. I believe it's finally resolved. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LMK if the client list are on the appropriate part of the README or not.