Skip to content

feat(playback): allow specifying multiple presets at once #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2023
Merged

feat(playback): allow specifying multiple presets at once #43

merged 3 commits into from
Oct 15, 2023

Conversation

Xenira
Copy link
Contributor

@Xenira Xenira commented Oct 14, 2023

Description of change

Allow to specify preset multiple times. All presets are played at the same time.

Closes #35

How has this been tested? (if applicable)

  • daktilo uses the default profile
  • daktilo -p musicbox uses musicbox profile only
  • daktilo -p default -p musicbox -p drumkit is an orchestra

@Xenira Xenira requested a review from orhun as a code owner October 14, 2023 11:35
@codecov-commenter
Copy link

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/args.rs 36.36% <0.00%> (-3.64%) ⬇️
src/main.rs 0.00% <0.00%> (ø)
src/lib.rs 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

orhun
orhun approved these changes Oct 15, 2023
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot! 🚀

@orhun orhun changed the title Allow to specify multiple presets at once (Resolves #35) feat(playback): allow specifying multiple presets at once Oct 15, 2023
@orhun orhun merged commit 4154b8c into orhun:main Oct 15, 2023
Xenira added a commit to Xenira/daktilo that referenced this pull request Oct 16, 2023
@Xenira @orhun
feat(playback): allow specifying multiple presets at once (orhun#43)
92f5507 
* feat(presets): Allow to specify multiple presets at once

* refactor: simplify preset selection

* docs(readme): mention orchestra

---------

Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to run multiple presets
3 participants
@Xenira @codecov-commenter @orhun