feat(ui): support shift+tab for going to the previous tab #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XXMA16 <xxma1610@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
========================================
- Coverage 3.34% 3.32% -0.01%
========================================
Files 19 19
Lines 2399 2412 +13
========================================
Hits 80 80
- Misses 2319 2332 +13 ☔ View full report in Codecov by Sentry. |
orhun
reviewed
Oct 7, 2024
There was a problem hiding this comment.
LGTM!
ShiftTab -> Back takes up a lot of space and might be a weird name
"Previous" is better :) (Bksp also uses "back")
Also, instead of adding ShiftTab it to the every tab, we can maybe add it only to General, to keep things short.
Another thing, I think it should come after "Tab->Next".
|
Should I change |
|
Hmm, that's actually a good idea :) |
Signed-off-by: XXMA16 <xxma1610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Implemented Shift+Tab for scrolling a tab back
Closes #63
Concerns
if else's inHexdumpCommand#parseto amatchShiftTab -> Backtakes up a lot of space and might be a weird nameCancelPreviousdoesn't really need acheck_subsince Hexdump is not the first tab