update minimum required bitcoin core version to v25 #4180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For this to work with testnet4 isn't v28 required? |
hi @emilcondrea - yes, I think you're right, but this is PR is to just bring the documentation up to date with the MIN_VERSION specified in the src/wallet.rs. |
|
Thanks! I'll merge this for now but will update the version or write something in the docs about using testnet4 in a follow-up PR. |
raphjaph
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4106 updated the required version of Bitcoin Core to 25 - this updates the documentation.
thanks to @so7ow for pointing this out