Skip to content

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Dec 10, 2023

Description

Fixes for the following (as separate commits)
#202
#201
#195
#194
#191
#198

How Has This Been Tested?

Test suite, manual testing with https://github.com/wadetregaskis/Swift-Benchmarks

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@hassila hassila requested a review from dimlio December 10, 2023 15:42
@hassila hassila changed the title Various outstanding fixes feat(minor): Various outstanding fixes Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #204 (de74d8c) into main (124e5fb) will increase coverage by 0.21%.
The diff coverage is 81.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   71.15%   71.36%   +0.21%     
==========================================
  Files          29       29              
  Lines        3719     3750      +31     
==========================================
+ Hits         2646     2676      +30     
- Misses       1073     1074       +1     
Files Coverage Δ
...stemStats/OperatingSystemStatsProducer+Linux.swift 96.72% <100.00%> (+0.09%) ⬆️
Tests/BenchmarkTests/AdditionalTests.swift 100.00% <100.00%> (ø)
Tests/BenchmarkTests/BenchmarkMetricsTests.swift 98.85% <100.00%> (+0.03%) ⬆️
...BenchmarkTests/OperatingSystemAndMallocTests.swift 100.00% <100.00%> (ø)
...urces/Benchmark/BenchmarkExecutor+Extensions.swift 69.35% <50.00%> (-0.65%) ⬇️
Sources/Benchmark/BenchmarkMetric+Defaults.swift 39.39% <50.00%> (+0.22%) ⬆️
Sources/Benchmark/BenchmarkResult.swift 72.62% <66.67%> (-0.04%) ⬇️
Sources/Benchmark/BenchmarkMetric.swift 71.12% <71.43%> (-0.12%) ⬇️
Sources/Benchmark/BenchmarkExecutor.swift 93.91% <83.33%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

Files Coverage Δ
...stemStats/OperatingSystemStatsProducer+Linux.swift 96.72% <100.00%> (+0.09%) ⬆️
Tests/BenchmarkTests/AdditionalTests.swift 100.00% <100.00%> (ø)
Tests/BenchmarkTests/BenchmarkMetricsTests.swift 98.85% <100.00%> (+0.03%) ⬆️
...BenchmarkTests/OperatingSystemAndMallocTests.swift 100.00% <100.00%> (ø)
...urces/Benchmark/BenchmarkExecutor+Extensions.swift 69.35% <50.00%> (-0.65%) ⬇️
Sources/Benchmark/BenchmarkMetric+Defaults.swift 39.39% <50.00%> (+0.22%) ⬆️
Sources/Benchmark/BenchmarkResult.swift 72.62% <66.67%> (-0.04%) ⬇️
Sources/Benchmark/BenchmarkMetric.swift 71.12% <71.43%> (-0.12%) ⬇️
Sources/Benchmark/BenchmarkExecutor.swift 93.91% <83.33%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124e5fb...de74d8c. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 10, 2023

@hassila hassila merged commit 0b15255 into main Dec 11, 2023
@hassila hassila deleted the fixes branch December 11, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants