Skip to content

check-absolute-path path checks needs to be more robust for non-existent paths + when shell sanitisation substitution should be done #195

@hassila

Description

@hassila
  • If the path you pass to --check-absolute-path doesn't exist, the check command will show Baseline 'Current_run' is EQUAL to the defined absolute baseline thresholds. (--check-absolute) instead of failing

  • My benchmark names had spaces at first, but when generating the threshold files, spaces would be replaced with underscores.
    That's all good, but when checking against those thresholds (using --check-absolute-path), they would also say the current run matched the defined thresholds, even when they didn't. I think it just couldn't find the right files, so it was basically the same bug from the previous bullet point manifesting itself. To get it to work, I had to replace spaces with underscores in the benchmark names for the thresholds to be picked up when running check.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions