"if Hardware::CPU.intel?" change from causes brew style linting errors #5736
Closed
alexfsong
started this conversation in
Ideas, Issue Triage, and General discussions
Replies: 1 comment
-
ah, yes, easy enough to fix thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The change to resolve issue #5348 causes linting errors due to unnecessary nested conditionals. When template code is rendered like the following:
brew style will throw the following error:
[Correctable] Consider merging nested conditions into outer if conditions. if Hardware::CPU.is_64_bit?
The corresponding change in the template will make the condition for arm64 a little less readable, but I think it's worth fixing.Beta Was this translation helpful? Give feedback.
All reactions