Support OpenTelemetry environment variable sampling rates #9227
Closed
marcus-crane
started this conversation in
Ideas
Replies: 2 comments 1 reply
-
That sounds fine to me with someone wants to PR it :) |
Beta Was this translation helpful? Give feedback.
1 reply
-
Closed by #9229 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hey there,
I was interested in setting up tracing for an existing Concourse deployment although I am hesitant to capture full traces given that, as a user, it isn't immediately clear how many spans I can expect Concourse to create.
My next step would be to set a sampling rate using an environment variable however I wouldn't expect that to work given that a 100% sample rate is currently hardcoded.
The Go SDK for OpenTelemetry checks enivironment variables first before overriding discovered values with hardcoded values which is described here but can also be observed in code as well.
According to the documentation, the default value is to always sample:
Given that, it should be fine to remove the hardcoded
AlwaysSample
rule which will retain the same behavior while unlocking the ability to introduce a sample rate via environment variableBeta Was this translation helpful? Give feedback.
All reactions