Skip to content

build: update major and minor tags update publishing #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

build: update major and minor tags update publishing #22

merged 1 commit into from
Sep 20, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Sep 20, 2023 •
edited
Loading

This PR adds a Github action to update tags automatically after publishing a new release. Validated in this job run.

@qweeah qweeah requested a review from shizhMSFT as a code owner September 20, 2023 02:39
@qweeah
build: update major and minor tags update publishing
53077ac 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Copy link
Contributor Author

qweeah commented Sep 20, 2023

Also, we need to allow actions to have write access to this repo, I am not sure if it's enabled because I don’t have access to check.

@shizhMSFT
Copy link
Contributor

Also, we need to allow actions to have write access to this repo, I am not sure if it's enabled because I don’t have access to check.

Write permission is checked.

shizhMSFT
shizhMSFT approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

note: this PR is inspired by notaryproject/notation-action#41

@shizhMSFT shizhMSFT merged commit ee7dbe1 into oras-project:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qweeah @shizhMSFT