Skip to content

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Mar 6, 2025

Resolves: #814

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (2ef884f) to head (17dff94).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   80.24%   80.19%   -0.05%     
==========================================
  Files          63       63              
  Lines        6053     6053              
==========================================
- Hits         4857     4854       -3     
- Misses        858      860       +2     
- Partials      338      339       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from Copilot March 6, 2025 11:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new documentation file that explains the concepts of targets in oras-go v2, including relevant interfaces, content stores, and usage diagrams.

  • Introduces the Targets documentation with detailed explanations and examples.
  • Provides diagrams and tables that illustrate the structure and functionality of various content stores.

Reviewed Changes

File Description
docs/Targets.md New documentation covering targets, interfaces, and content stores

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

docs/Targets.md:302

  • The word 'Funciton' is misspelled; it should be 'Function'.
| Funciton Name  | API endpoint |

docs/Targets.md:312

  • The word 'Funciton' is misspelled; it should be 'Function'.
| Funciton Name | API endpoint |

docs/Targets.md:326

  • The word 'arbitary' is misspelled; it should be 'arbitrary'.
| File Store       | Stores location-addressable content on file system | Partial (For named blobs only) | Yes | Packaging arbitary files |

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from Copilot March 6, 2025 12:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds comprehensive documentation for the new concepts of Targets in oras-go v2 by explaining various interfaces, content stores, and providing visual diagrams.

  • Added documentation outlining the interfaces (Storage, GraphStorage, Target, GraphTarget) and their functionalities.
  • Provided detailed examples and diagrams for the implemented content stores (Memory, OCI, File, and Repository).
  • Included a flowchart to help users choose the appropriate content store.

Reviewed Changes

File Description
docs/Targets.md Detailed documentation for Targets, including interface definitions and examples

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds documentation to explain the concepts of targets and content stores in oras-go v2. It introduces a new doc file with detailed explanations, examples including mermaid diagrams, and usage guidelines for the built-in content stores.

Reviewed Changes

File Description
docs/Targets.md New documentation detailing targets and content stores in oras-go v2

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from Copilot March 7, 2025 09:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds comprehensive documentation covering Targets and various content store concepts in oras-go v2. It introduces detailed descriptions of interfaces, usage examples with JSON and mermaid diagrams, and practical guidance for selecting the appropriate content store.

Reviewed Changes

File Description
docs/Targets.md New documentation detailing Targets, Storage, and content stores

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from TerryHowe March 10, 2025 04:44
@Wwwsylvia
Copy link
Member Author

Thanks @TerryHowe for the review! I addressed your comments, please take a look again.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Wwwsylvia Wwwsylvia requested a review from Copilot March 11, 2025 02:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds detailed documentation for the targets and content store concepts introduced in oras-go v2.

  • Introduces an overview of the four primary interfaces for storage and targets.
  • Provides comprehensive examples, including JSON snippets, Mermaid diagrams, and command-line outputs to illustrate different content store scenarios.

Reviewed Changes

File Description
docs/Targets.md New documentation covering targets, graph storage, and various content store types

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Wwwsylvia Wwwsylvia merged commit f3f718b into oras-project:main Mar 11, 2025
9 checks passed
@Wwwsylvia Wwwsylvia deleted the docs_concepts_targets branch March 11, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to clarify common concepts in oras-go v2
4 participants