Skip to content

fix(file.Store): fix race condition on restoring the same named content #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix(file.Store): fix race condition on restoring the same named content #731

merged 2 commits into from
Mar 21, 2024

Conversation

shizhMSFT
Copy link
Contributor

Fix #730

@shizhMSFT shizhMSFT marked this pull request as draft March 20, 2024 14:37
@shizhMSFT shizhMSFT marked this pull request as ready for review March 20, 2024 14:37
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (8f9f505) to head (9fa9b44).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   75.63%   75.85%   +0.21%     
==========================================
  Files          63       63              
  Lines        5997     6000       +3     
==========================================
+ Hits         4536     4551      +15     
+ Misses       1078     1069       -9     
+ Partials      383      380       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT force-pushed the fix_flaky_file_store_test branch 3 times, most recently from ff4f1f7 to 1aa76c9 Compare March 20, 2024 16:50
Wwwsylvia
Wwwsylvia reviewed Mar 21, 2024
View reviewed changes
@shizhMSFT shizhMSFT force-pushed the fix_flaky_file_store_test branch from 1aa76c9 to 4a0b59d Compare March 21, 2024 05:44
@shizhMSFT
fix(file.Store): fix race condition on restoring the same named content
26ea720 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
test: add a unit test case for race condition
9fa9b44 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT force-pushed the fix_flaky_file_store_test branch from 4a0b59d to 9fa9b44 Compare March 21, 2024 05:46
Wwwsylvia
Wwwsylvia approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 9b6f321 into oras-project:main Mar 21, 2024
@shizhMSFT shizhMSFT deleted the fix_flaky_file_store_test branch March 21, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file.Store has race conditions on restoring the same named content
2 participants
@shizhMSFT @Wwwsylvia