Skip to content

fix: check empty registry name #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: check empty registry name #729

merged 1 commit into from
Mar 20, 2024

Conversation

shizhMSFT
Copy link
Contributor

Fix #698

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (4503c31) to head (b94b39b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #729   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          63       63           
  Lines        5981     5981           
=======================================
  Hits         4523     4523           
  Misses       1076     1076           
  Partials      382      382

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TerryHowe
TerryHowe approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

qweeah
qweeah approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although IANAM

@wangxiaoxuan273
Copy link
Contributor

LGTM although IANAM

Wwwsylvia
Wwwsylvia approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
fix: check empty registry name
b94b39b 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT force-pushed the fix_ref_empty_domain branch from 65b4359 to b94b39b Compare March 20, 2024 12:34
@Wwwsylvia Wwwsylvia merged commit d3ff5dc into oras-project:main Mar 20, 2024
@shizhMSFT shizhMSFT deleted the fix_ref_empty_domain branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

+2 more reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@qweeah qweeah qweeah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: registry.ParseReference returns false positive when registry is empty
5 participants
@shizhMSFT @wangxiaoxuan273 @TerryHowe @qweeah @Wwwsylvia