Skip to content

fix(DynamicStore): retry setCredsStore on next PUT #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix(DynamicStore): retry setCredsStore on next PUT #728

merged 4 commits into from
Mar 21, 2024

Conversation

shizhMSFT
Copy link
Contributor

Fix #727

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.63%. Comparing base (d3ff5dc) to head (04b7408).

Files Patch % Lines
internal/syncutil/once.go 81.25% 2 Missing and 1 partial ⚠️
registry/remote/credentials/store.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   75.62%   75.63%   +0.01%     
==========================================
  Files          63       63              
  Lines        5981     5997      +16     
==========================================
+ Hits         4523     4536      +13     
- Misses       1076     1078       +2     
- Partials      382      383       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wwwsylvia
Wwwsylvia reviewed Mar 20, 2024
View reviewed changes
@shizhMSFT
fix: retry setCredsStore on next call
8aefdae 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
fix: correct race conditions
2890d86 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
refactor: simplify Once code
dab300f 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
test: add test for OnceOrRetry
04b7408 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Wwwsylvia
Wwwsylvia approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 8f9f505 into oras-project:main Mar 21, 2024
@shizhMSFT shizhMSFT deleted the fix_store_put branch March 21, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsequent DynamicStore.Put calls do not set credential store once failure
2 participants
@shizhMSFT @Wwwsylvia