Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oras-project/oras-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.0
Choose a base ref
...
head repository: oras-project/oras-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.1
Choose a head ref
  • 5 commits
  • 15 files changed
  • 4 contributors

Commits on Jul 4, 2023

  1. build(deps): bump golang.org/x/sync from 0.2.0 to 0.3.0 (#524)

    @dependabot @shizhMSFT
    dependabot[bot] authored and shizhMSFT committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f1c44e1 View commit details
    Browse the repository at this point in the history

  2. fix(oci): create blobs dir and define blobs dir name constant (#520) 

    https://github.com/opencontainers/image-spec/blob/v1.0/image-layout.md#content
specifies that the blobs dir must exist, so the changed ensureDir in
this PR is a bugfix.

The addition and use of the ociBlobsDir constant is more of a cleanup
suggestion, and I can remove it if necessary. I've also asked for it to
be added upstream at
opencontainers/image-spec#1069 but that will
probably take significantly longer.

Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
    @sparr @shizhMSFT
    sparr authored and shizhMSFT committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    9480525 View commit details
    Browse the repository at this point in the history

  3. fix: improve errors for ReadAll and loadIndexfile (#526) 

    NewWithContext refers to both the `oci-layout` and `index.json` as "OCI
Image Layout", this PR fixes the latter.

ReadAll is a deeper change that will improve error reporting for a lot
of cases, at the cost of error volume. Some or all of that change could
happen higher up to satisfy this particular issue. I think the
expected/actual size output belongs here. There seem to be more than a
few code paths in this and other repos that end up calling ReadAll
multiple times without reporting which call produced an error so I think
it's appropriate to also output the digest here, but that's less
compelling.

The Verify comment clears up confusion I encountered while working on
this issue. "verifies size" implies checking for both too big AND too
small, but it only checks if the file is bigger (or reader is longer)
than expected.

Fixes #432

Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
    @sparr @shizhMSFT
    sparr authored and shizhMSFT committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f3d7906 View commit details
    Browse the repository at this point in the history

  4. refactor: upgrade go mod to image-spec v1.1.0-rc4 and fix the missi… 

    …ng types (#536)

Resolves: #530

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
    @Wwwsylvia @shizhMSFT
    Wwwsylvia authored and shizhMSFT committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    cd01930 View commit details
    Browse the repository at this point in the history

  5. chore: enable workflows for release branches (#537) 

    Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
    @Wwwsylvia @shizhMSFT
    Wwwsylvia authored and shizhMSFT committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a152732 View commit details
    Browse the repository at this point in the history
Loading