This repository was archived by the owner on Apr 7, 2024. It is now read-only.
feat: support trace with executables #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 6 6
Lines 382 382
=======================================
Hits 315 315
Misses 45 45
Partials 22 22 |
|
Some general questions:
|
shizhMSFT
reviewed
Jul 10, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
JeyJeyGao
reviewed
Jul 11, 2023
Two-Hearts
reviewed
Jul 11, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
reviewed
Jul 11, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
reviewed
Jul 12, 2023
trace/trace.go
Outdated
| if oldStart != nil { | ||
| start := trace.ExecuteStart | ||
| trace.ExecuteStart = func(executableName, action string) { | ||
| start(executableName, action) |
There was a problem hiding this comment.
Added the check and refactored this part of code.
trace/trace.go
Outdated
| if oldDone != nil { | ||
| done := trace.ExecuteDone | ||
| trace.ExecuteDone = func(executableName, action string, err error) { | ||
| done(executableName, action, err) |
There was a problem hiding this comment.
Added the check and refactored this part of code.
trace/trace.go
Outdated
| if trace == nil { | ||
| return ctx | ||
| } | ||
| oldTrace, _ := ctx.Value(executableTraceContextKey{}).(*ExecutableTrace) |
There was a problem hiding this comment.
ContextExecutableTrace() should be reused for this line.
There was a problem hiding this comment.
Resued ContextExecutableTrace()
|
I just wonder why this isn't being added to oras-go |
@TerryHowe It will be added to |
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
approved these changes
Jul 13, 2023
native_store_test.go
Outdated
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "io" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/oras-project/oras-credentials-go/trace" | ||
|
|
Wwwsylvia
reviewed
Jul 13, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
This was referenced Jul 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63