chore: remove [Preview] label on --include-subject for oras pull
#1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
This PR promotes the --include-subject flag for the oras pull command from preview status to stable by removing the [Preview] label from its help text and associated test expectations.
- Removes
[Preview]label from the--include-subjectflag description - Updates corresponding end-to-end test to no longer expect the preview marking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/oras/root/pull.go | Removes [Preview] label from --include-subject flag description |
| test/e2e/suite/command/pull.go | Removes test assertion that checked for preview marking on --include-subject flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 85.27% 85.25% -0.03%
==========================================
Files 143 143
Lines 6739 6739
==========================================
- Hits 5747 5745 -2
- Misses 704 706 +2
Partials 288 288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
--include-subject for oras pull--include-subject for oras pull
--include-subject for oras pull--include-subject for oras pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the
[Preview]label on theinclude-subjectflag for theoras pullcommand. This means to promote this flag from preview level to stable.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1811
Please check the following list: