refactor(perf): optimize cases with no child referrers in recursiveCopy #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 84.92% 85.17% +0.24%
==========================================
Files 129 129
Lines 5751 5766 +15
==========================================
+ Hits 4884 4911 +27
+ Misses 617 609 -8
+ Partials 250 246 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…sition Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…2e (oras-project#1724) Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…a6126986d9 to 2.6.0 (oras-project#1725) Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…cenarios Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…marshal failures Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…ilures Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
approved these changes
May 13, 2025
…e errors correctly Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 28, 2025
…py (oras-project#1729) Signed-off-by: Billy Zha <jinzha1@microsoft.com>
6 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the
recursiveCopyfunction to handle cases where there are no child manifests or referrers, ensuring the function exits early in such scenarios. This change improves the function's efficiency and robustness.Please check the following list: