Skip to content

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Every time I'm in this file, I get confused about what opts is because that is used outside this everywhere for options

Similar to #1666

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (00db5dc) to head (3512d1a).

Files with missing lines Patch % Lines
cmd/oras/internal/option/remote.go 89.74% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
- Coverage   84.84%   84.77%   -0.07%     
==========================================
  Files         127      127              
  Lines        5722     5722              
==========================================
- Hits         4855     4851       -4     
- Misses        617      621       +4     
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r would be even better.

@TerryHowe TerryHowe merged commit 457e342 into oras-project:main May 13, 2025
6 checks passed
@TerryHowe
Copy link
Member Author

LGTM. r would be even better.

Yeh, but sooner get this merged now. remo is at least easier to search for

qweeah pushed a commit to qweeah/oras that referenced this pull request May 13, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants