Skip to content

backport(fix): show KB in progress bar instead of kB (#1623) #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

backport(fix): show KB in progress bar instead of kB (#1623) #1707

merged 1 commit into from
Apr 25, 2025

Conversation

Wwwsylvia
Copy link
Member

What this PR does / why we need it:
Backporting 43d5ac4

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah @Wwwsylvia
fix(ux): show KB in progress bar instead of kB (oras-project#1623)
9925423 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (bf135dd) to head (9925423).
Report is 1 commits behind head on release-1.2.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.2    #1707   +/-   ##
============================================
  Coverage        82.95%   82.95%           
============================================
  Files              107      107           
  Lines             4652     4652           
============================================
  Hits              3859     3859           
  Misses             564      564           
  Partials           229      229

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shizhMSFT
shizhMSFT approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit e974796 into oras-project:release-1.2 Apr 25, 2025
8 checks passed
@Wwwsylvia Wwwsylvia deleted the backport_1.2 branch April 25, 2025 08:10
@BrewTestBot BrewTestBot mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@qweeah qweeah Awaiting requested review from qweeah qweeah is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wwwsylvia @shizhMSFT @qweeah