Skip to content

Conversation

Wwwsylvia
Copy link
Member

What this PR does / why we need it:
This PR adds documentation for the output formats for oras repo ls and oras repo tags commands.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1547
Related to #1758

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@Wwwsylvia Wwwsylvia requested a review from Copilot July 2, 2025 08:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the formatted‐output proposal with documentation for the oras repo ls and oras repo tags commands, including JSON schemas and examples.

  • Adds table of contents entries for oras repo ls and oras repo tags
  • Defines JSON schema and usage examples for both commands
  • Illustrates default vs JSON output behavior for oras repo ls
Comments suppressed due to low confidence (3)

docs/proposals/formatted-output.md:13

  • The TOC includes a link to "Verify local files" but there’s no matching section in the document. Either add the section content or remove this entry to prevent a broken anchor.
    - [Verify local files](#verify-local-files)

docs/proposals/formatted-output.md:637

  • [nitpick] For consistency with the oras repo ls section, consider adding an example of the default (text) output for oras repo tags in addition to the JSON example.
### oras repo tags

docs/proposals/formatted-output.md:637

  • [nitpick] The JSON schema for oras repo tags only includes tags. If downstream tooling needs context (e.g., registry or repository name), consider adding those fields or explicitly documenting that they’re omitted by design.
### oras repo tags

Wwwsylvia added 2 commits July 2, 2025 16:40
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (ce45791) to head (bb6de1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1763      +/-   ##
==========================================
- Coverage   85.29%   85.26%   -0.04%     
==========================================
  Files         133      133              
  Lines        5882     5882              
==========================================
- Hits         5017     5015       -2     
- Misses        616      618       +2     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wwwsylvia Wwwsylvia marked this pull request as ready for review July 2, 2025 08:41
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Wwwsylvia

@Wwwsylvia Wwwsylvia merged commit fd82860 into oras-project:main Jul 4, 2025
7 checks passed
@Wwwsylvia Wwwsylvia deleted the spec_repo_format branch July 4, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants