-
Notifications
You must be signed in to change notification settings - Fork 201
docs(spec): define output formats for oras repo commands #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the formatted‐output proposal with documentation for the oras repo ls
and oras repo tags
commands, including JSON schemas and examples.
- Adds table of contents entries for
oras repo ls
andoras repo tags
- Defines JSON schema and usage examples for both commands
- Illustrates default vs JSON output behavior for
oras repo ls
Comments suppressed due to low confidence (3)
docs/proposals/formatted-output.md:13
- The TOC includes a link to "Verify local files" but there’s no matching section in the document. Either add the section content or remove this entry to prevent a broken anchor.
- [Verify local files](#verify-local-files)
docs/proposals/formatted-output.md:637
- [nitpick] For consistency with the
oras repo ls
section, consider adding an example of the default (text) output fororas repo tags
in addition to the JSON example.
### oras repo tags
docs/proposals/formatted-output.md:637
- [nitpick] The JSON schema for
oras repo tags
only includestags
. If downstream tooling needs context (e.g., registry or repository name), consider adding those fields or explicitly documenting that they’re omitted by design.
### oras repo tags
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1763 +/- ##
==========================================
- Coverage 85.29% 85.26% -0.04%
==========================================
Files 133 133
Lines 5882 5882
==========================================
- Hits 5017 5015 -2
- Misses 616 618 +2
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c0a950d
to
0770d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Wwwsylvia
What this PR does / why we need it:
This PR adds documentation for the output formats for
oras repo ls
andoras repo tags
commands.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #1547
Related to #1758
Please check the following list: