-
Notifications
You must be signed in to change notification settings - Fork 201
ci: add dependabot support for Dockerfile #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add dependabot support for Dockerfile #1761
Conversation
Signed-off-by: tanya <tanyabhatnagar119@gmail.com>
Signed-off-by: tanya <tanyabhatnagar119@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to downgrade the go version? #1710 does not request downgrading go to 1.22.
@shizhMSFT Thanks for the clarification! I had initially interpreted #1710 as a request to align everything to Go 1.22 for consistency, since some workflows were still using 1.21. Happy to update the PR to keep everything on 1.24 instead — will push the changes shortly. |
Signed-off-by: tanya <tanyabhatnagar119@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Go version used in GitHub Actions workflows to 1.22 (restoring 1.24.2) and extends Dependabot to track Dockerfile base image updates.
- Bump Go version to 1.22 across build, lint, CodeQL, and release workflows
- Add Docker package-ecosystem to
.github/dependabot.yml
for weekly updates
Comments suppressed due to low confidence (1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
+ Coverage 85.26% 85.29% +0.03%
==========================================
Files 133 133
Lines 5882 5882
==========================================
+ Hits 5015 5017 +2
+ Misses 618 616 -2
Partials 249 249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you update the PR title to reflect this is dependabot for Docker
@TerryHowe sure, i've done that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the Go version in all relevant GitHub Actions workflows to 1.22, as requested in issue #1710. The affected workflows include:
Reverted earlier downgrade and restored Go 1.24.2 in all GitHub Actions workflows.
Additionally, this PR updates the dependabot.yml configuration to include support for Dockerfile version updates, enabling Dependabot to track and suggest updates to base images used in the project.
All unit tests were run locally using Go 1.24.3 for compatibility, and the changes are expected to pass CI without issues.
Fixes #1710