feat: show repo tags with --oci-layout-path in repo tags command
#1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
+ Coverage 85.39% 85.46% +0.07%
==========================================
Files 137 137
Lines 5950 5966 +16
==========================================
+ Hits 5081 5099 +18
+ Misses 618 616 -2
Partials 251 251 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 10 commits
June 27, 2025 17:33
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
requested changes
Jun 30, 2025
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
TerryHowe
reviewed
Jun 30, 2025
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds and refactors the functionality for showing repository tags using the new --oci-layout-path flag in the oras repo tags command.
- Added e2e tests for validating tags filtering in OCI layout.
- Updated the tag filtering logic in the repo tags command to support repository-scoped filtering.
- Extended the help message to demonstrate the new OCI layout usage.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/e2e/suite/command/repo.go | Added new test cases to verify correct tag filtering. |
| cmd/oras/root/repo/tags.go | Updated tag filtering logic to enable OCI layout support. |
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
|
Need to consider the case that |
added 2 commits
July 1, 2025 19:18
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
added 3 commits
July 10, 2025 14:38
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
c1d6eb3 to
2b8c9b9
Compare
2b8c9b9 to
fbbba33
Compare
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the new feature of showing repo tags with
--oci-layout-pathinrepo tagscommand. This feature applies to the scenario where the user stores images from multiple repositories in the same OCI layout directory, and put the full references of the images as tags. For example, an OCI layout may contain the following tags:In this case, given the command
oras repo tags --oci-layout-path layout-dir test.com/bar, the output would beas
v1is the tag under the repositorytest.com/bar.oras repo tagscommand now has three functionalities (list tags, list associated tags and showing repo tags) and they are implemented in the code in a mixed way. I think it would be better if we can refactor the code.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1612
Please check the following list: