Skip to content

refactor: add manifest delete metadata handler #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

refactor: add manifest delete metadata handler #1633

merged 3 commits into from
Feb 26, 2025

Conversation

wangxiaoxuan273
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1551
Fixes #1542

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Xiaoxuan Wang added 2 commits February 25, 2025 16:54
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (cbb255e) to head (d34d776).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
+ Coverage   84.39%   84.45%   +0.06%     
==========================================
  Files         124      125       +1     
  Lines        5651     5661      +10     
==========================================
+ Hits         4769     4781      +12     
+ Misses        627      625       -2     
  Partials      255      255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wwwsylvia
Wwwsylvia approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 98ae479 into oras-project:main Feb 26, 2025
8 checks passed
@Wwwsylvia Wwwsylvia mentioned this pull request Apr 24, 2025
Merged
6 tasks
@wangxiaoxuan273 wangxiaoxuan273 deleted the manifest-delete-handler branch August 25, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@qweeah qweeah Awaiting requested review from qweeah qweeah is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor oras manifest delete to use handlers for command output All oras commands should use handlers to display command output
3 participants
@wangxiaoxuan273 @Wwwsylvia @shizhMSFT