fix(ux): show KB in progress bar instead of kB #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 120 120
Lines 5460 5460
=======================================
Hits 4609 4609
Misses 604 604
Partials 247 247 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
6 tasks
Wwwsylvia
pushed a commit
to Wwwsylvia/oras
that referenced
this pull request
Apr 25, 2025
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Wwwsylvia
added a commit
that referenced
this pull request
Apr 25, 2025
6 tasks
This was referenced May 16, 2025
Open
Open
Open
Open
Open
This was referenced May 16, 2025
Bump oras-project/oras from 1.2.1 to 1.2.3 in
lib/functions/general/oci-oras.sh
RadxaStephen/build#4
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a minor UX fix on the download speed display. According to JEDEC unit prefix standard,
KBshould be used since the size base is 12 not 10.