Skip to content

refactor: move --no-tty out of option.Common #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 24, 2025
Merged

refactor: move --no-tty out of option.Common #1699

merged 15 commits into from
Apr 24, 2025

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 18, 2025 •
edited
Loading

What this PR does / why we need it:

This PR moves notty out of option.Common and changes the descriptions of the no-tty flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1630

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

working code
c4c09cc 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (16e4682) to head (571c8a6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/internal/option/terminal.go 80.00% 2 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 40.00% 2 Missing and 1 partial ⚠️
cmd/oras/root/blob/fetch.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   84.81%   84.66%   -0.15%     
==========================================
  Files         126      127       +1     
  Lines        5702     5718      +16     
==========================================
+ Hits         4836     4841       +5     
- Misses        616      624       +8     
- Partials      250      253       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Xiaoxuan Wang added 3 commits April 18, 2025 16:56
update descriptions
84196a6 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
changed updatetty
831499b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
refinement
a963c6f 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 marked this pull request as ready for review April 21, 2025 06:25
Xiaoxuan Wang added 2 commits April 21, 2025 14:30
Merge branch 'main' into discover-help-doc
df6d604
update a unit test
d07981e 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
shizhMSFT requested changes Apr 23, 2025
View reviewed changes
renamed struct
5b5d182 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Wwwsylvia
Wwwsylvia approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a thought

shizhMSFT
shizhMSFT requested changes Apr 23, 2025
View reviewed changes
shizhMSFT
shizhMSFT reviewed Apr 24, 2025
View reviewed changes
Xiaoxuan Wang added 3 commits April 24, 2025 17:02
resolve comments
1b9a49f 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
fix bug
63a432a 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
fix bug
1e86a70 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
shizhMSFT reviewed Apr 24, 2025
View reviewed changes
shizhMSFT
shizhMSFT reviewed Apr 24, 2025
View reviewed changes
Xiaoxuan Wang added 2 commits April 24, 2025 17:32
updated
835ae7b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Merge branch 'main' into discover-help-doc
71fc81f
shizhMSFT
shizhMSFT approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xiaoxuan Wang added 2 commits April 24, 2025 18:38
rename function
680bc03 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
renamed function
4428859 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Wwwsylvia
Wwwsylvia approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

increase coverage
571c8a6 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@Wwwsylvia Wwwsylvia merged commit 3a02c88 into oras-project:main Apr 24, 2025
8 checks passed
@Wwwsylvia Wwwsylvia mentioned this pull request Apr 24, 2025
Merged
6 tasks
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
@wangxiaoxuan273 @FeynmanZhou
refactor: move --no-tty out of option.Common (oras-project#1699)
ac62442 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 deleted the discover-help-doc branch August 25, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@qweeah qweeah Awaiting requested review from qweeah qweeah is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect description of the --no-tty flag for oras discover
3 participants
@wangxiaoxuan273 @Wwwsylvia @shizhMSFT