fix: lint explicitly ignore various close errors #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1684 +/- ##
==========================================
- Coverage 85.13% 85.13% -0.01%
==========================================
Files 129 129
Lines 5766 5764 -2
==========================================
- Hits 4909 4907 -2
Misses 611 611
Partials 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7fd73e9 to
22682cf
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
22682cf to
6d1f382
Compare
Wwwsylvia
reviewed
Apr 10, 2025
This was referenced May 5, 2025
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I pulled these changes out of #1677 because they are different from the other errors handled in that pull request. In order to support the latest version of lint, we need to handle or ignore various returned errors.