Skip to content

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Fix platform config type.

Which issue(s) this PR fixes

Fixes #1517

@Wwwsylvia
Copy link
Member

Looks like some E2E tests failed

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.84%. Comparing base (97cb376) to head (7578a00).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   83.84%   83.84%           
=======================================
  Files         118      118           
  Lines        5156     5156           
=======================================
  Hits         4323     4323           
  Misses        592      592           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe
Copy link
Member Author

Looks like some E2E tests failed

Fixed.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am not a maintainer

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 270aa65 into oras-project:main Oct 29, 2024
8 checks passed
@TerryHowe TerryHowe deleted the fix-config-type branch September 11, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras push --artifact-platform is not compatible with oras pull --platform and similar commands
3 participants