Skip to content

refactor: Use printer object for output #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

refactor: Use printer object for output #1426

merged 1 commit into from
Jun 22, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Change the last calls to fmt.Fprint to use the printer object.

@TerryHowe
refactor: Use printer object for output
1bc45dc 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (145ea7a) to head (1bc45dc).

Files Patch % Lines
cmd/oras/root/login.go 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
- Coverage   85.32%   85.26%   -0.07%     
==========================================
  Files         106      106              
  Lines        3810     3808       -2     
==========================================
- Hits         3251     3247       -4     
- Misses        334      336       +2     
  Partials      225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah
qweeah approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can add a dedicated option to reduce duplicated output.NewPrinter(cmd.OutOrStdout(), opts.Verbose) though

@TerryHowe TerryHowe merged commit 780c7da into oras-project:main Jun 22, 2024
@TerryHowe
Copy link
Member Author

I think we can add a dedicated option to reduce duplicated output.NewPrinter(cmd.OutOrStdout(), opts.Verbose) though

I should probably step back and look at where this has gone. Generally, I'm pretty happy, but I'm sure there is room for improvement somewhere.

@qweeah qweeah mentioned this pull request Jun 23, 2024
Merged
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TerryHowe @qweeah