chore: Increase print test coverage #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 107 107
Lines 3795 3795
=======================================
Hits 3238 3238
Misses 333 333
Partials 224 224 ☔ View full report in Codecov by Sentry. |
qweeah
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Need to rename test function to be compliant with suggested practices in Golang docs:
E.g. the naming convention to declare examples for the package, a function F, a type T and method M on type T are:
func Example() { ... }
func ExampleF() { ... }
func ExampleT() { ... }
func ExampleT_M() { ... }
Multiple example functions for a package/type/function/method may be provided by appending a distinct suffix to the name. The suffix must start with a lower-case letter.
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add more print test coverage