chore(ux): improve error message for bad annotation format #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes is aligned with the PRD but you need to fix the unit tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
+ Coverage 81.44% 81.46% +0.01%
==========================================
Files 68 68
Lines 3746 3749 +3
==========================================
+ Hits 3051 3054 +3
Misses 487 487
Partials 208 208 ☔ View full report in Codecov by Sentry. |
e689e50 to
52a4eea
Compare
qweeah
reviewed
Jan 19, 2024
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
61a6a3b to
c86ff51
Compare
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
…ect#1243) Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1215
Please check the following list:
current display:
