Ensure stats are initialized at 0. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the array values will be null, which will show up as nulls in the tirex-status --raw output. fixes openstreetmap#29
woodpeck
reviewed
Sep 11, 2024
|
I don't think that is easier. The status call just converts the status object to JSON as is.
To do what you suggest means manually outputting the json for the status call and converting as it goes.
…On Mi, 11 Sep 2024 19:03 +02:00, Frederik Ramm ***@***.***> wrote:
***@***.**** commented on this pull request.
Would it perhaps be easier to leave the "null" values in, and simply
convert to integer on output?
—
Reply to this email directly, view it on GitHub
<#67 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAMCZKQVJN7YRG42ZEVMTZWBZVZAVCNFSM6AAAAABNWJJF7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJXHE3TQMZUHE>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Amanda
|
|
In Tirex::Status->read() you could iterate over the relevant fields and replace null by 0. That would only affect the output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the array values will be null, which will show up as nulls in the tirex-status --raw output.
I am not 100% sure if this is correct. and would appreciate feedback. I am also not a very skilled Perl programmer, and would appreciate feedback & suggestions on how I solved this issue. (i.e. feel free to rewrite it to be idomiatic, or correct)
fixes #29