OCM-17150 | cross projects wif-config update for second milestone #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miguelhbrito The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Mainly, the fix was to remove\ comment-out the federated option from update cmd. So could you pls post some test results to indicate this is working as expected i.e the federated project option is no longer available for user on the update cmd |
|
/lgtm |
ckandag
added a commit
that referenced
this pull request
Aug 6, 2025
-8ba748b wif config name on cluster review and describe (#816) -be14307 Add deprecation header handling -dd6c671 Handle deprecation header in all CLI commands -f10fefa Add Makefile target to install ginkgo and skip test in case 'pass' is not available -8593695 Remove redundant documentation msg -ccfbfe1 Fix linter issues -c12b3f4 availability zone help text flag to multiple cloud providers (#815) -53547a9 Handle deprecation header in all missed CLI commands -90b8edc Update Konflux references -d51c67b Revert "Handle deprecation header in all missed CLI commands" -27e48a0 Revert "Handle deprecation header in all CLI commands" -784b40e Fix revert conflicts -61e3381 OCM-17277 | feat: Use deprecation transport to handle backend API deprecation -443db81 OCM-17277 | feat: bump ocm-common and run go mod tidy -676d290 update sdk to latest -e8580f9 cross project wif config support (#831) -069c3bf cross projects wif-config update for second milestone (#840) -499d78f update tekton references
ckandag
added a commit
that referenced
this pull request
Aug 6, 2025
-8ba748b wif config name on cluster review and describe (#816) -be14307 Add deprecation header handling -dd6c671 Handle deprecation header in all CLI commands -f10fefa Add Makefile target to install ginkgo and skip test in case 'pass' is not available -8593695 Remove redundant documentation msg -ccfbfe1 Fix linter issues -c12b3f4 availability zone help text flag to multiple cloud providers (#815) -53547a9 Handle deprecation header in all missed CLI commands -90b8edc Update Konflux references -d51c67b Revert "Handle deprecation header in all missed CLI commands" -27e48a0 Revert "Handle deprecation header in all CLI commands" -784b40e Fix revert conflicts -61e3381 OCM-17277 | feat: Use deprecation transport to handle backend API deprecation -443db81 OCM-17277 | feat: bump ocm-common and run go mod tidy -676d290 update sdk to latest -e8580f9 cross project wif config support (#831) -069c3bf cross projects wif-config update for second milestone (#840) -499d78f update tekton references
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp create wif-config --name wif-ocm-cross-project-int --project sda-ccs-3 --federated-project sda-ccs-1
...
2025/07/30 14:07:34 wif-config '2kc05kkj86qqocnuot84trniodotnsua' created successfully.
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp update wif-config 2kc05kkj86qqocnuot84trniodotnsua
...
2025/07/30 14:12:55 wif-config '2kc05kkj86qqocnuot84trniodotnsua' updated successfully.
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp create wif-config --name wif-ocm-nom-cross-project-int --project sda-ccs-3
...
2025/07/30 14:18:49 wif-config '2kc0b5vkagb0tsmelquo7d1pts4ghvqs' created successfully.
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp update wif-config 2kc0b5vkagb0tsmelquo7d1pts4ghvqs --federated-project sda-ccs-3
Error: unknown flag: --federated-project
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp update wif-config 2kc0b5vkagb0tsmelquo7d1pts4ghvqs
...
2025/07/30 14:24:30 wif-config '2kc0b5vkagb0tsmelquo7d1pts4ghvqs' updated successfully.
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp list wif-config
ID DISPLAY NAME PROJECT ID VERSIONS
2j2ff5dfl05neprupv75qn450hchenjp mipereir-int sda-ccs-3 [v4.19 v4.18 v4.17]
2k304ruis37bskpqmonr57f33agdbrre ck-int sda-ccs-3 [v4.19 v4.18 v4.17]
2kc05kkj86qqocnuot84trniodotnsua wif-ocm-cross-project-int sda-ccs-3 [v4.19 v4.18 v4.17]
2kc0b5vkagb0tsmelquo7d1pts4ghvqs wif-ocm-nom-cross-project-int sda-ccs-3 [v4.19 v4.18 v4.17]
Old wif-config:
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp update wif-config 2j2ff5dfl05neprupv75qn450hchenjp
...
2025/07/30 14:53:24 wif-config '2j2ff5dfl05neprupv75qn450hchenjp' updated successfully.
No longer appears in --help:
mipereir@mipereir-thinkpadp1gen4i:~/myprojects/ocm-cli$ ./ocm gcp update wif-config --help
...
Usage:
ocm gcp update wif-config [ID|Name] [flags]
Flags:
-h, --help help for wif-config
-m, --mode string How to perform the operation. Valid options are:
auto (default): Resource changes will be automatically applied using the
current GCP account.
manual: Commands necessary to modify GCP resources will be output
as a script to be run manually.
(default "auto")
--output-dir string Directory to place generated files (defaults to current directory)
--version string Version of OpenShift to configure the WIF resources for