This repository was archived by the owner on Jul 11, 2023. It is now read-only.
[backport] Add more robust CRD conversion patching #5303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watch CRDs over a span of 15s to make sure that the CRD conversion patch is not overwritten by another reconciler Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
keithmattix
approved these changes
Mar 31, 2023
shalier
approved these changes
Mar 31, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## release-v1.2 #5303 +/- ##
================================================
+ Coverage 68.79% 68.83% +0.04%
================================================
Files 210 210
Lines 15679 15680 +1
================================================
+ Hits 10786 10794 +8
+ Misses 4842 4835 -7
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Apr 3, 2023
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Backport #5300 to release-v1.2
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? No