Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

[backport] cherry-pick 68e99eb to release-v1.1 #5071

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

nshankar13
Copy link
Contributor

@nshankar13 nshankar13 commented Sep 2, 2022

Remove crd conversion webhook (#5065)

Signed-off-by: nshankar13 nshankar@microsoft.com

Description: Cherry pick commit to remove conversion webhook, resolves #4967.

Testing done: Tested install locally, and upgrade from v1.0.0 to this version.

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [X]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [X]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [X]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

@codecov-commenter
Copy link

Codecov Report

Merging #5071 (1d77740) into release-v1.1 (0171d84) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-v1.1    #5071      +/-   ##
================================================
+ Coverage         68.92%   69.04%   +0.11%     
================================================
  Files               219      208      -11     
  Lines             15111    14768     -343     
================================================
- Hits              10416    10196     -220     
+ Misses             4640     4518     -122     
+ Partials             55       54       -1     
Flag Coverage Δ
unittests 69.04% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/osm-bootstrap/osm-bootstrap.go 38.49% <0.00%> (-6.39%) ⬇️
pkg/metricsstore/metricsstore.go 91.90% <ø> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Remove crd conversion webhook (openservicemesh#5065)

Signed-off-by: nshankar13 <nshankar@microsoft.com>

Add health handler

Signed-off-by: nshankar13 <nshankar@microsoft.com>
Signed-off-by: nshankar13 <nshankar@microsoft.com>
Signed-off-by: nshankar13 <nshankar@microsoft.com>
@steeling
Copy link
Contributor

steeling commented Sep 6, 2022

can you upgrade the chart versions to v1.1.2?

@keithmattix keithmattix merged commit 2bb5ad5 into openservicemesh:release-v1.1 Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants