This repository was archived by the owner on Jul 11, 2023. It is now read-only.
[backport] cherry-pick 68e99ebb to release-v1.2 #5069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd075e0 to
8a126ef
Compare
steeling
previously approved these changes
Sep 2, 2022
keithmattix
previously approved these changes
Sep 2, 2022
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
8a126ef to
6f42427
Compare
Codecov Report
@@ Coverage Diff @@
## release-v1.2 #5069 +/- ##
================================================
+ Coverage 68.62% 68.79% +0.17%
================================================
Files 220 210 -10
Lines 15941 15657 -284
================================================
- Hits 10939 10771 -168
+ Misses 4950 4835 -115
+ Partials 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
keithmattix
approved these changes
Sep 2, 2022
trstringer
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick commit 68e99eb from PR #5065 to release-v1.2 branch to fix circular dependency bug.
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?