This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Plumb trust domain through to helm chart #4877
Merged
+75
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
trstringer
suggested changes
Jul 6, 2022
jaellio
reviewed
Jul 6, 2022
jaellio
approved these changes
Jul 6, 2022
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4877 +/- ##
=======================================
Coverage 68.71% 68.71%
=======================================
Files 220 220
Lines 15907 15914 +7
=======================================
+ Hits 10930 10936 +6
- Misses 4925 4926 +1
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
trstringer
approved these changes
Jul 7, 2022
|
Image scan failure is a known issue: alpinelinux/docker-alpine#261. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Mattix II keithmattix2@gmail.com
Description:
Since we're not releasing full MRC support in v1.2, this PR allows users to set a custom trust domain by plumbing it through the helm chart as a command line flag to the 3 binaries (controller, bootstrap, and injector).
Testing done:
Add test to make sure trust domain is set on the issuers
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?