Fix MRC status #4856
Fix MRC status #4856
Conversation
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
cmd/osm-bootstrap/osm-bootstrap.go
Outdated
| _, err = b.configClient.ConfigV1alpha2().MeshRootCertificates(b.namespace).UpdateStatus(context.Background(), createdMRC, metav1.UpdateOptions{}) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I'd combine these 2 lines in one:
if _, err := (...); err != nil {}There was a problem hiding this comment.
That's a pretty long line to embed in an if statement; breaking it up seems like it would be more reasonable
|
In |
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4856 +/- ##
==========================================
- Coverage 69.51% 69.50% -0.01%
==========================================
Files 219 219
Lines 16033 16041 +8
==========================================
+ Hits 11146 11150 +4
- Misses 4833 4837 +4
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Keith Mattix II keithmattix2@gmail.com
Description:
Correctly sets the preset MRC's status on initial create and fixes a typo on the printer column of the MRC CRD
Testing done:
Ran the demo and checked the MRC manifest
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? N/A