Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Jun 22, 2022

Description:
Addresses comments made in #4706
#4702

Co-authored-by: Nicolas Lamirault nicolas.lamirault@gmail.com
Signed-off-by: Shalier Xia shalierxia@microsoft.com

Testing done:

Affected area:

Functional Area
Other [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #4842 (d10ad37) into main (8fd236e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4842      +/-   ##
==========================================
+ Coverage   69.49%   69.52%   +0.02%     
==========================================
  Files         218      219       +1     
  Lines       15881    16002     +121     
==========================================
+ Hits        11037    11125      +88     
- Misses       4792     4823      +31     
- Partials       52       54       +2     
Flag Coverage Δ
unittests 69.52% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/envoy/rds/route/route_config.go 92.39% <0.00%> (-7.61%) ⬇️
pkg/envoy/rds/route/rbac.go 93.54% <0.00%> (ø)
tests/scenarios/helpers.go 72.41% <0.00%> (ø)
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd236e...d10ad37. Read the comment docs.

nlamirault and others added 14 commits June 28, 2022 12:26
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…on arm64

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…s to preinstall, define amd64 and arm64 in cleanup nodeAffinity field

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
Co-authored-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@trstringer trstringer merged commit 45b19ea into openservicemesh:main Jun 29, 2022
@shalier shalier deleted the selectors branch November 16, 2022 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants