This repository was archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 274
Abstract webhook logic to prepare for rotating certificates #4833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e13975
to
a829887
Compare
nojnhuh
reviewed
Jun 22, 2022
jaellio
reviewed
Jun 23, 2022
keithmattix
reviewed
Jun 28, 2022
4ecaeed
to
19b4ca4
Compare
nojnhuh
approved these changes
Jun 29, 2022
jaellio
approved these changes
Jun 29, 2022
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
19b4ca4
to
e496e2a
Compare
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
e496e2a
to
db9485c
Compare
This was referenced Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract the webhook logic so that it shares a common base set of methods for creating the server.
This is in preparation to allow these webhook servers to rotate their certificates
There's a couple things this PR does:
Part of #4839