Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

steeling
Copy link
Contributor

@steeling steeling commented Jun 20, 2022

Abstract the webhook logic so that it shares a common base set of methods for creating the server.

This is in preparation to allow these webhook servers to rotate their certificates

There's a couple things this PR does:

  1. Leverage a single, underlying webhook server that starts up the appropriate server with TLS and an ability to rotate certificates.
  2. remove ports as flags as these were neither exposed through helm, and there was a bug where if a user did specify a different port via the flags, it wouldn't actually be plumbed through properly.
  3. Remove inconsistency with health checks across the 3 backend systems, by creating a simple healthcheck on the metrics port.
  4. Switch the TLS Config from a hard coded cert to a getter function, to allow for future rotation

Part of #4839

@steeling steeling force-pushed the feature/webhooks branch 11 times, most recently from 1e13975 to a829887 Compare June 22, 2022 01:01
@steeling steeling force-pushed the feature/webhooks branch 4 times, most recently from 4ecaeed to 19b4ca4 Compare June 29, 2022 17:33
steeling added 3 commits June 29, 2022 16:03
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants