Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

trstringer
Copy link
Contributor

@trstringer trstringer commented Jun 21, 2022

Update Kerbernetes matrix testing by removing Kubernetes v1.21 and
adding v1.23 and v1.24. Also update the README to include the oldest
supported Kubernetes version.

Signed-off-by: Thomas Stringer thomas@trstringer.com

Affected area:

Functional Area
Tests [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No.

  2. Is this a breaking change? No.

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? Updates soon by @zr-msft

Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do the following:

  1. Bump min version defined by kubeVersion in charts/osm/Chart.yaml
  2. Update docs/release_notes.md to note that support for v1.20.x is dropped

You also need to update min_k8s_version in osm-docs/config.toml

@trstringer
Copy link
Contributor Author

Could you also do the following:

  1. Bump min version defined by kubeVersion in charts/osm/Chart.yaml
  2. Update docs/release_notes.md to note that support for v1.20.x is dropped

You also need to update min_k8s_version in osm-docs/config.toml

Changes 1 and 2 have been made. As for osm-docs, I believe @zr-msft will be making those doc changes.

@zr-msft
Copy link
Contributor

zr-msft commented Jun 21, 2022

@shashankram @trstringer ACK on the doc changes corresponding to this PR. Will link as soon as i have it staged.

Update Kerbernetes matrix testing by removing Kubernetes v1.21 and
adding v1.23 and v1.24. Also update the README to include the oldest
supported Kubernetes version.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
@trstringer trstringer force-pushed the thstring/update-kubernetes-testing-versions branch from 5b91bb5 to f0f2ffb Compare June 22, 2022 20:37
@codecov-commenter
Copy link

Codecov Report

Merging #4836 (f0f2ffb) into main (08c646b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4836      +/-   ##
==========================================
+ Coverage   69.49%   69.51%   +0.01%     
==========================================
  Files         218      218              
  Lines       15881    15881              
==========================================
+ Hits        11037    11040       +3     
+ Misses       4792     4789       -3     
  Partials       52       52              
Flag Coverage Δ
unittests 69.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c646b...f0f2ffb. Read the comment docs.

@trstringer trstringer merged commit 831f023 into openservicemesh:main Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants