This repository was archived by the owner on Jul 11, 2023. It is now read-only.
envoy/cds: add nil check for ConnectionSettings #4821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of rate limiting to the UpstreamTrafficSetting spec, it is possible for the UpstreamTrafficSetting object to be non nil while having its ConnectionSettings as nil. Add nil check so the code doesn't panic when ConnectionSettings is nil and RateLimit is configured. Signed-off-by: Shashank Ram <shashr2204@gmail.com>
nojnhuh
approved these changes
Jun 15, 2022
trstringer
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the addition of rate limiting to the
UpstreamTrafficSetting spec, it is possible
for the UpstreamTrafficSetting object to be non
nil while having its ConnectionSettings as nil.
Add nil check so the code doesn't panic when
ConnectionSettings is nil and RateLimit is configured.
Testing done:
Unit test
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
n/a