Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

self-nominate steeling as a maintainer #4824

Merged
merged 1 commit into from
Jun 30, 2022
Merged

self-nominate steeling as a maintainer #4824

merged 1 commit into from
Jun 30, 2022

Conversation

steeling
Copy link
Contributor

No description provided.

@allenlsy
Copy link
Contributor

@steeling can you add me as maintainer in this PR as well?

@allenlsy
Copy link
Contributor

Discussed offline. Additional code maintainer will be added in separate PR.

@trstringer
Copy link
Contributor

+1

@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 22, 2022

+1

jaellio
jaellio approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@jaellio jaellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

shashankram
shashankram reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@steeling could you rebase this change, and also add your username to the CODEOWNERS file

@steeling
self-nominate steeling as a maintainer
9dc6ca3 
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@steeling steeling requested a review from keithmattix as a code owner June 30, 2022 16:52
keithmattix
keithmattix approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@trstringer
Copy link
Contributor

This is good to merge as a majority (5/7) of the existing maintainers are in agreement.

@trstringer trstringer merged commit 854edda into openservicemesh:main Jun 30, 2022
@draychev
Copy link
Contributor

+1
Glad to see @steeling join the maintainer list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snehachhabria snehachhabria Awaiting requested review from snehachhabria

@draychev draychev Awaiting requested review from draychev

5 more reviewers

@trstringer trstringer trstringer approved these changes

@keithmattix keithmattix keithmattix approved these changes

@nojnhuh nojnhuh nojnhuh approved these changes

@shashankram shashankram shashankram approved these changes

@jaellio jaellio jaellio approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@steeling @allenlsy @trstringer @nojnhuh @draychev @keithmattix @shashankram @jaellio