This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Increase retry timeout cert-manager #4795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nshankar13 <nshankar@microsoft.com>
nojnhuh
approved these changes
Jun 7, 2022
jaellio
approved these changes
Jun 7, 2022
|
Thanks @nshankar13! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nshankar13 nshankar@microsoft.com
Description: Openshift nightly job was failing the e2e_certmanager test. After testing this locally, it seems to be an intermittent issue due to https://cert-manager.io/docs/concepts/webhook/#webhook-connection-problems-shortly-after-cert-manager-installation (as detailed in the InstallCertManager method in common.go). I increased the retry timeout to 20s and ran this locally several times on OpenShift and the issue seems to be mitigated.
Resolves: #4784
Testing done: Ran 10+ times locally on OpenShift and the e2e_certmanager test passed every time.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?