This repository was archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 274
ref(contributors): update contributor roles and requirements #4776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a new Reviewer role to the contributor ladder - Clarifies role requirements - Defines process for adding codeowner permissions per directory Signed-off-by: jaellio <jaellio@microsoft.com>
…nal PR Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
0543ed8
to
f46d971
Compare
shashankram
suggested changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a blocking comment so we don't accidentally merge this till the comment is addressed.
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
jaellio
reviewed
Jun 9, 2022
jaellio
reviewed
Jun 9, 2022
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
trstringer
approved these changes
Jun 13, 2022
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
nojnhuh
approved these changes
Jun 14, 2022
@shalier going to review this again |
shashankram
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Clarifies role requirements
Defines the process for adding codeowner permissions per directory
Resolves #4774
Affected area:
Please answer the following questions with yes/no.
kubernetes
CNCF
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?