Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

ref(contributors): update contributor roles and requirements #4776

Merged
merged 5 commits into from
Jun 14, 2022

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Jun 1, 2022

Description:
Clarifies role requirements
Defines the process for adding codeowner permissions per directory
Resolves #4774

Affected area:

Functional Area
Other [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? yes
  1. Is this a breaking change? no

  2. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

- Adds a new Reviewer role to the contributor ladder
- Clarifies role requirements
- Defines process for adding codeowner permissions per directory

Signed-off-by: jaellio <jaellio@microsoft.com>
…nal PR

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier shalier force-pushed the contributorLadder branch from 0543ed8 to f46d971 Compare June 1, 2022 01:21
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a blocking comment so we don't accidentally merge this till the comment is addressed.

@shashankram shashankram self-requested a review June 6, 2022 17:19
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier shalier requested a review from jaellio June 9, 2022 20:19
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shashankram
Copy link
Member

@shalier going to review this again

@shashankram shashankram merged commit 5ee33f3 into openservicemesh:main Jun 14, 2022
@shalier shalier deleted the contributorLadder branch November 16, 2022 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OSM contributor roles
6 participants