This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(certs): get Vault token from Secret #4753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
- Coverage 69.08% 68.86% -0.23%
==========================================
Files 227 227
Lines 16311 16442 +131
==========================================
+ Hits 11269 11322 +53
- Misses 4990 5068 +78
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
55da548 to
3ec9a72
Compare
3ec9a72 to
5faff82
Compare
nojnhuh
reviewed
May 31, 2022
nojnhuh
approved these changes
Jun 1, 2022
shalier
approved these changes
Jun 6, 2022
shashankram
approved these changes
Jun 21, 2022
If the Vault token option is not set, the token will be obtained from the secret referenced in the SecretKeyRef. Currently, the Vault token must still be set as an option if Vault is the cert provider. In a subsquent change, all cert provider flags will be removed from the osm-bootstrap, osm-controller, and osm-injector. These values will instead be obtained from the MRC created by the osm-bootstrap and populated using the preset-mesh-root-certificate Signed-off-by: jaellio <jaellio@microsoft.com>
Signed-off-by: jaellio <jaellio@microsoft.com>
22c3a48 to
9c57a33
Compare
Signed-off-by: jaellio <jaellio@microsoft.com>
9c57a33 to
1fba496
Compare
nojnhuh
approved these changes
Jun 28, 2022
keithmattix
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If the Vault token option is not set, the token will be obtained
from the secret referenced in the SecretKeyRef. Currently, the
Vault token must still be set as an option if Vault is the cert
provider. In a subsequent change, all cert provider flags will be
removed from the osm-bootstrap, osm-controller, and osm-injector.
These values will instead be obtained from the MRC created by the
osm-bootstrap and populated using the preset-mesh-root-certificate.
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? No