This repository was archived by the owner on Jul 11, 2023. It is now read-only.
cli/verifier: add control plane health probe checks #4751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds HTTP and HTTPS liveness probe checks to control plane health verification command - Moves unnecessary constants pkg in the generic httpserver directory and consolidates those into the constants pkg - Fixes a bug in the existing proxy_get port-forwarding code used by the verifier, where a connection leak exists due to not closing the response - Hides the probe implementation behind an interface so that the verifier can be unit tested without needing to hack the port-forwarding dependency - Consolidates /healthz constants for webhooks Part of openservicemesh#4634 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
jaellio
approved these changes
May 20, 2022
trstringer
approved these changes
May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds HTTP and HTTPS liveness probe checks to control
plane health verification command
Moves unnecessary constants pkg in the generic
httpserver directory and consolidates those
into the constants pkg
Fixes a bug in the existing proxy_get port-forwarding
code used by the verifier, where a connection leak
exists due to not closing the response
Hides the probe implementation behind an interface
so that the verifier can be unit tested without
needing to hack the port-forwarding dependency
Consolidates /healthz constants for webhooks
Part of #4634
Testing done:
Success
Failure
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
n/a